Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

IE Overlay Height

#18

In IE, the height of the overlay is set to the view height. If you scroll the page then you can see that the overlay does not cover all of it.

Solution: use the clientHeight instead.

At line 792 of window.js, simply plug in document.body.clientHeight. This does the trick.

Reported by skapig · August 8th, 2008 @ 06:58 AM

State: unconfirmed
Milestone: 1.0
Assigned to: Ryan Johnson Ryan Johnson

Activity

  1. niko
    niko

    +1. This works for me, too.

    August 19th, 2008 @ 01:20 AM

  2. satoshi
    satoshi

    It occurred in IE7.you can see this condition at attached img.

    August 26th, 2008 @ 01:48 AM

  3. Ryan Johnson
    Ryan Johnson
    • State changed from unconfirmed to resolved

    There is another aspect of this problem that I am working on, but this is definitely the fix for IE, and I've incorporated the change. Thanks!

    September 9th, 2008 @ 11:53 AM

  4. gordo11231
    gordo11231

    This fix doesn't well work when the document is very short. (In IE 7 at least.) This seems better:

            positionOverlay: function(){
                var dimensions = document.viewport.getDimensions();
                Control.Overlay.container.setStyle({
                    width: Math.max(
                                document.body.clientWidth,
                                dimensions.width) + 'px',
                    height: Math.max(document.body.clientHeight,
                                dimensions.height) + 'px'
                });
            }
    
    

    November 16th, 2008 @ 06:51 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.