Bug in contextmenu.js? (addItem)
Reported by Bob MacGregor | October 22nd, 2008 @ 07:53 PM | in 1.0
This code looks questionable:
addItem: function(params){
if(!'enabled' in params)
params.enabled = true;
this.items.push(params);
return this;
},
Perhaps it should be
addItem: function(params){
if(!('disabled') in params)
params.enabled = true;
this.items.push(params);
return this;
},
Comments and changes to this ticket
-
Nathan L Smith May 18th, 2009 @ 04:44 PM
- Tag set to “control.contextmenu”
Wouldn't if(!('disabled') in params) evaluate to if(true in params)? That wouldn't make any sense. This does need to be looked at, though.
-
Nathan L Smith May 19th, 2009 @ 08:02 PM
- State changed from “unconfirmed” to “resolved”
Duplicate of #24, which is fixed. Closing.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
NOTE: Please do not open tickets here. If you have an issue, please open it on http://github.com/syntacticx/livepipe-ui/issues/
High quality widgets and controls for web 2.0 applications built using the Prototype JavaScript Framework. Each control is well tested, highly extensible, fully documented and degrades gracefully for non JavaScript enabled browsers where possible. MIT licensed and actively maintained.
Bob MacGregor