#18 ✓resolved
skapig

IE Overlay Height

Reported by skapig | August 8th, 2008 @ 06:58 AM | in 1.0

In IE, the height of the overlay is set to the view height. If you scroll the page then you can see that the overlay does not cover all of it.

Solution: use the clientHeight instead.

At line 792 of window.js, simply plug in document.body.clientHeight. This does the trick.

Comments and changes to this ticket

  • satoshi

    satoshi August 26th, 2008 @ 01:48 AM

    It occurred in IE7.you can see this condition at attached img.

  • Ryan Johnson

    Ryan Johnson September 9th, 2008 @ 11:53 AM

    • State changed from “unconfirmed” to “resolved”

    There is another aspect of this problem that I am working on, but this is definitely the fix for IE, and I've incorporated the change. Thanks!

  • gordo11231

    gordo11231 November 16th, 2008 @ 06:51 AM

    This fix doesn't well work when the document is very short. (In IE 7 at least.) This seems better:

            positionOverlay: function(){
                var dimensions = document.viewport.getDimensions();
                Control.Overlay.container.setStyle({
                    width: Math.max(
                                document.body.clientWidth,
                                dimensions.width) + 'px',
                    height: Math.max(document.body.clientHeight,
                                dimensions.height) + 'px'
                });
            }
    
    

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

NOTE: Please do not open tickets here. If you have an issue, please open it on http://github.com/syntacticx/livepipe-ui/issues/

High quality widgets and controls for web 2.0 applications built using the Prototype JavaScript Framework. Each control is well tested, highly extensible, fully documented and degrades gracefully for non JavaScript enabled browsers where possible. MIT licensed and actively maintained.

Attachments

Referenced by

Pages