Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Bug in contextmenu.js? (addItem)

#34

This code looks questionable:

addItem: function(params){
    if(!'enabled' in params)
        params.enabled = true;
    this.items.push(params);
    return this;
},

Perhaps it should be

addItem: function(params){
    if(!('disabled') in params)
        params.enabled = true;
    this.items.push(params);
    return this;
},

Reported by Bob MacGregor · October 22nd, 2008 @ 07:53 PM

State: resolved
Milestone: 1.0
Assigned to: Ryan Johnson Ryan Johnson

Activity

  1. Nathan L Smith
    Nathan L Smith
    • Tag set to control.contextmenu

    Wouldn't if(!('disabled') in params) evaluate to if(true in params)? That wouldn't make any sense. This does need to be looked at, though.

    May 18th, 2009 @ 04:44 PM

  2. Nathan L Smith
    Nathan L Smith
    • State changed from unconfirmed to resolved

    Duplicate of #24 ContextMenu item enable, which is fixed. Closing.

    May 19th, 2009 @ 08:02 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.