Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Control.Window has flicker after appearing

#35

Control.Window.finishOpen positions windows AFTER it shows them. As a result, there is a noticeable flicker between when it appears and when the content appears on my Linux/FF3.

Below diff fixes it.


diff --git a/src/window.js b/src/window.js
index dac0adf..eae64d5 100755
--- a/src/window.js
+++ b/src/window.js
@@ -569,9 +569,11 @@ Control.Window = Class.create({
                                        this.notify('afterOpen');
                                }.bind(this)
                        });
-               }else
+            this.position(event);
+               }else{
+            this.position(event);
                        this.container.show();
-               this.position(event);
+        }
                if(!(this.options.draggable || this.options.resizable) && this.options.position == 'center')
                        Event.observe(window,'resize',this.positionHandler,false);
                if(!this.options.draggable && this.options.position == 'center')
@@ -926,4 +928,4 @@ Object.extend(Control.LightBox,{
                                throw $break;
                }
        }
-});
\ No newline at end of file
+});

Reported by cory · October 26th, 2008 @ 08:53 PM

State: hold
Milestone: 1.0
Assigned to: Ryan Johnson Ryan Johnson

Activity

  1. cory
    cory

    The above was trashed by lighthouse, so I attached the patch instead.

    October 26th, 2008 @ 08:54 PM

  2. cory
    cory

    I just noticed that the iframe shim does not ever get positioned, with or without my patch. This is also a potential problem.

    October 26th, 2008 @ 09:12 PM

  3. Nathan L Smith
    Nathan L Smith
    • Tag changed from artifacts, control.modal, control.window, diff, finishopen, flicker, patch, position, show to control.modal, control.window, finishopen, flicker, patch, position

    May 19th, 2009 @ 04:22 PM

  4. Nathan L Smith
    Nathan L Smith
    • State changed from unconfirmed to hold

    August 9th, 2009 @ 07:08 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.