Control.Window has flicker after appearing
Reported by cory | October 26th, 2008 @ 08:53 PM | in 1.0
Control.Window.finishOpen positions windows AFTER it shows them. As a result, there is a noticeable flicker between when it appears and when the content appears on my Linux/FF3.
Below diff fixes it.
diff --git a/src/window.js b/src/window.js
index dac0adf..eae64d5 100755
--- a/src/window.js
+++ b/src/window.js
@@ -569,9 +569,11 @@ Control.Window = Class.create({
this.notify('afterOpen');
}.bind(this)
});
- }else
+ this.position(event);
+ }else{
+ this.position(event);
this.container.show();
- this.position(event);
+ }
if(!(this.options.draggable || this.options.resizable) && this.options.position == 'center')
Event.observe(window,'resize',this.positionHandler,false);
if(!this.options.draggable && this.options.position == 'center')
@@ -926,4 +928,4 @@ Object.extend(Control.LightBox,{
throw $break;
}
}
-});
\ No newline at end of file
+});
Comments and changes to this ticket
-
cory October 26th, 2008 @ 08:54 PM
The above was trashed by lighthouse, so I attached the patch instead.
-
cory October 26th, 2008 @ 09:12 PM
I just noticed that the iframe shim does not ever get positioned, with or without my patch. This is also a potential problem.
-
Nathan L Smith May 19th, 2009 @ 04:22 PM
- Tag changed from “artifacts, control.modal, control.window, diff, finishopen, flicker, patch, position, show” to “control.modal, control.window, finishopen, flicker, patch, position”
-
Nathan L Smith August 9th, 2009 @ 07:08 PM
- State changed from “unconfirmed” to “hold”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
NOTE: Please do not open tickets here. If you have an issue, please open it on http://github.com/syntacticx/livepipe-ui/issues/
High quality widgets and controls for web 2.0 applications built using the Prototype JavaScript Framework. Each control is well tested, highly extensible, fully documented and degrades gracefully for non JavaScript enabled browsers where possible. MIT licensed and actively maintained.
cory