Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Size issues in IE

#60

This a fix suggestion for window.js line 788 to 796.

It takes the Max height for either the document or browser window and sets that as the overlay height so it always covers all the content.

@@@javascript

//IE only
positionOverlay: function(){
    var h = Math.max( document.documentElement.clientHeight, document.body.clientHeight ) + 'px';
    var w = Math.max( document.documentElement.clientWidth, document.body.clientWidth ) + 'px';

    Control.Overlay.container.setStyle({
        width: w,
        height: h
    });
}

Reported by chadanuk · July 6th, 2009 @ 08:38 AM

State: invalid
Milestone: 1.0
Assigned to: Ryan Johnson Ryan Johnson

Activity

  1. Larry Ruiz
    Larry Ruiz

    I had similar issues the problem in ie7 is that the body doesn't expand has the content in some particular cases,
    in my case i have the following css:

    html, body {
    height: 100%;
}

#container {
    min-height: 100%;
    margin: 0 auto -23px;
    width: 1024px;
}

    It seems that body doesn't get bigger than the browser window even if the container block does, in ie6 works perfectly.

    So in my case were we are using ie7 makes sense to apply the styles solution to the overlay --> (Control.Overlay.container.setStyle(Control.Overlay.styles);

    Hope that this help for a solution.

    July 14th, 2009 @ 09:44 AM

  2. Nathan L Smith
    Nathan L Smith
    • Assigned user cleared.
    • State changed from new to unconfirmed

    July 31st, 2009 @ 01:13 PM

  3. steamshift
    steamshift
    • Assigned user set to Ryan Johnson 
    
//IE only
positionOverlay: function(){
    var h = Math.max( document.documentElement.clientHeight, document.documentElement.scrollHeight ) + 'px';
    var w = Math.max( document.documentElement.clientWidth, document.documentElement.scrollWidth ) + 'px';
    
    Control.Overlay.container.setStyle({
            width: w,
            height: h
        });
}

    found this to be the most effective ...

    August 7th, 2009 @ 05:13 AM

  4. Nathan L Smith
    Nathan L Smith
    • State changed from unconfirmed to invalid

    August 13th, 2009 @ 08:09 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.