#60 ✓invalid
chadanuk

Size issues in IE

Reported by chadanuk | July 6th, 2009 @ 08:38 AM | in 1.0

This a fix suggestion for window.js line 788 to 796.

It takes the Max height for either the document or browser window and sets that as the overlay height so it always covers all the content.

@@@javascript

//IE only
positionOverlay: function(){
    var h = Math.max( document.documentElement.clientHeight, document.body.clientHeight ) + 'px';
    var w = Math.max( document.documentElement.clientWidth, document.body.clientWidth ) + 'px';

    Control.Overlay.container.setStyle({
        width: w,
        height: h
    });
}

Comments and changes to this ticket

  • Larry Ruiz

    Larry Ruiz July 14th, 2009 @ 09:44 AM

    I had similar issues the problem in ie7 is that the body doesn't expand has the content in some particular cases,
    in my case i have the following css:

    html, body {
        height: 100%;
    }
    
    #container {
        min-height: 100%;
        margin: 0 auto -23px;
        width: 1024px;
    }
    

    It seems that body doesn't get bigger than the browser window even if the container block does, in ie6 works perfectly.

    So in my case were we are using ie7 makes sense to apply the styles solution to the overlay --> (Control.Overlay.container.setStyle(Control.Overlay.styles);

    Hope that this help for a solution.

  • Nathan L Smith

    Nathan L Smith July 31st, 2009 @ 01:13 PM

    • Assigned user cleared.
    • State changed from “new” to “unconfirmed”
  • steamshift

    steamshift August 7th, 2009 @ 05:13 AM

    • Assigned user set to “Ryan Johnson”
    
    //IE only
    positionOverlay: function(){
        var h = Math.max( document.documentElement.clientHeight, document.documentElement.scrollHeight ) + 'px';
        var w = Math.max( document.documentElement.clientWidth, document.documentElement.scrollWidth ) + 'px';
        
        Control.Overlay.container.setStyle({
                width: w,
                height: h
            });
    }
    

    found this to be the most effective ...

  • Nathan L Smith

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

NOTE: Please do not open tickets here. If you have an issue, please open it on http://github.com/syntacticx/livepipe-ui/issues/

High quality widgets and controls for web 2.0 applications built using the Prototype JavaScript Framework. Each control is well tested, highly extensible, fully documented and degrades gracefully for non JavaScript enabled browsers where possible. MIT licensed and actively maintained.

Referenced by

Pages