Close button on modals
-
Caleb JonesI would vehemently oppose automatically putting a close button in modal windows. Control (form a programmer's perspective) is one of the reasons I use livepipe's modal implementation.
That said, I'm not opposed to the addition of a parameter that would automatically generate a close button. That way those who want complete control can have it, and those who want a canned solution can do so (best of both worlds).
-
Ryan Johnson
- State changed from unconfirmed to confirmed
Duly noted and agreed. Maybe something like this syntax:
new Control.Modal({
closeOnClick: new Element('div')
});
?
-
Suneth Mendis
Hi Caleb,
I didn't mean to have a close button always present on Modals. That would be defeat the whole purpose of using Modal control. All I wanted to have an option to include a close, should there is a need; like the way I use Modal in my application. (And obviously after some feedback from very average users.
Ryan, that's exactly what i would like. Thanks mate!
-
Suneth Mendis
Forgive me for all the typos!
-
-
Nathan L Smith
- Tag changed from control.modal to control.modal, feature
-
Nathan L Smith
- State changed from confirmed to hold
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.