IE6 + https + Control.Modal = error
-
Juriy Zaytsev
IE tries to insert an element into a "body" when body has not yet been finished loading. This shouldn't appear if code is executed once DOM has been fully loaded.
document.observe('dom:loaded', function(){ // do stuff here }) -
Ryan Johnson
Thank you sir!
On Thu, Jun 19, 2008 at 6:49 PM, Lighthouse
wrote:
-
jeff (at jeffhartman)
- Tag set to control.window, https, ie
I was getting the "Internet Explorer cannot open the Internet Site ..." message and this fixed it. Thanks!
Now, however, my close link in the modal no longer works.
Do you know what I can do to fix that?
-
hobodave
This is fixed by changing line #319 of livepipe.js as follows:
diff --git a/src/livepipe.js b/src/livepipe.js index 7905e60..dc3efcd 100644 --- a/src/livepipe.js +++ b/src/livepipe.js @@ -316,7 +316,7 @@ var IframeShim = Class.create({ initialize: function() { this.element = new Element('iframe',{ style: 'position:absolute;filter:progid:DXImageTransform.Microsoft.Alpha(opacity=0);display:none', - src: 'javascript:void(0);', + src: 'javascript:false;', frameborder: 0 }); $(document.body).insert(this.element); -
hobodave
- Tag changed from control.window, https, ie to control.modal, control.window, https, ie
Correction: the previous inserts 'false' in the page. The following takes care of that, this technique is used in jQuery.
diff --git a/src/livepipe.js b/src/livepipe.js index 7905e60..dc3efcd 100644 --- a/src/livepipe.js +++ b/src/livepipe.js @@ -316,7 +316,7 @@ var IframeShim = Class.create({initialize: function() { this.element = new Element('iframe',{ style: 'position:absolute;filter:progid:DXImageTransform.Microsoft.Alpha(opacity=0);display:none',src: 'javascript:void(0);',src: 'javascript:false;document.write("");', frameborder: 0 }); $(document.body).insert(this.element);
-
hobodave
@@@javascript diff --git a/src/livepipe.js b/src/livepipe.js index 7905e60..dc3efcd 100644 --- a/src/livepipe.js +++ b/src/livepipe.js @@ -316,7 +316,7 @@ var IframeShim = Class.create({
initialize: function() { this.element = new Element('iframe',{ style: 'position:absolute;filter:progid:DXImageTransform.Microsoft.Alpha(opacity=0);display:none',src: 'javascript:void(0);',src: 'javascript:false;document.write("");', frameborder: 0 }); $(document.body).insert(this.element);
-
hobodave
well, lighthouse is looking like ass, I dont know why
-
DavePBand
This is such a shame, as none of the above solutions work for me, and It is such a nice control (except for the IE6 issue).
any updates on this issue?
-
Nathan L Smith
- State changed from unconfirmed to resolved
-
hobodave
- Assigned user changed from Ryan Johnson to Nathan L Smith
Why was this closed as resolved? It still exists and has not been addressed.
-
Nathan L Smith
@hobodave:
- We've moved to github for issue tracking. I've reopened this there: http://github.com/syntacticx/livepipe-ui/issues/#issue/19
- What revision are you using? I looks like your patch above was applied at some point, I think.
- I've created an issue-tests branch to try and reproduce errors like this: http://github.com/syntacticx/livepipe-ui/tree/issue-tests
- I've been unable to reproduce this using http://github.com/syntacticx/livepipe-ui/blob/issue-tests/test/issu...
- If something's missing there, could you send a pull request or a patch?
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.