Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Control.Overlay does not resize properly on IE

#2

With IE7 (Vista)

  • I scroll IE
  • I play with control.modal

=> The overlay is sized to the viewport and not to the full page. So

when scrolled half of the page si with the overlay

Reported by Ryan Johnson · June 13th, 2008 @ 10:43 AM

State: resolved
Milestone: 1.0
Assigned to: Ryan Johnson Ryan Johnson

Activity

  1. venu
    venu

    It happens on both IE6 and IE7 not just vista.

    Steps to reproduce:

    1. Open the URL http://livepipe.net/control/window in IE

    2. Click on Model Window link and scroll to the bottom of the screen.

    Expected:

    The overlay should cover the full screen.

    June 14th, 2008 @ 07:11 AM

  2. Ryan Johnson
    Ryan Johnson

    I think this should be fixed in the latest version, can you check?

    Added Control.Overlay.positionOverlay handler on scroll for IE.

    June 19th, 2008 @ 05:58 PM

  3. Rich Sbarro
    Rich Sbarro

    This issue appears to still exist on the livepipe.net site as of this posting. I also ran into it on my local projects as well.

    Control.Modal works fine in IE7 if there is no scrollbar. If there is a scrollbar, then it will only gray out a portion of the screen, and it will allow the user to scroll the screen.

    June 22nd, 2008 @ 06:37 PM

  4. Andy
    Andy
    • Tag set to control.modal, control.overlay, control.window, ie

    document.viewport.getDimensions(); does not return a different value once you scroll/resize. In order to do that, call document.viewport. getScrollOffsets(); and add it to the dimensions.

    Something like:

    var dimensions = document.viewport.getDimensions();

    var offsets = document.viewport.getScrollOffsets();

    Control.Overlay.container.setStyle({

    width: dimensions.width + offsets.left + 'px',

    height: dimensions.height + offsets.top + 'px'

    });

    July 10th, 2008 @ 10:34 AM

  5. Juan
    Juan

    The last tip did not work, as the dimensions were set once but upon scrolling or resizing the overlay still remained in its original spot rather than scrolling with the viewport.

    This, however, fixed it for me (after the modal window opens):

    Control.Overlay.container.setStyle({

    position: 'fixed',

    left: '0px',

    top: '0px',

    right: '0px',

    bottom: '0px'

    });

    might be redundant, but it work.

    Minor glitch: sometimes when resizing in ie, the overlay wont resize immediately but will upon scrolling. shrug

    Hope this helps somebody.

    July 26th, 2008 @ 03:38 AM

  6. Juan
    Juan

    Peter:

    yikes, hadn't noticed that. That's what i get for not testing in IE 6. Thankfully code hasnt made it to test team =).

    Anyway, still got trouble with IE6, I put that inside the options I extend the container with. I also tried putting them in the options directly passed in to the Modal constructor. both get executed, but IE6 just dislikes it.

    Thoughts?

    August 1st, 2008 @ 05:06 PM

  7. Tim Holahan
    Tim Holahan

    The solution proposed in ticket 18 (http://livepipe.lighthouseapp.co... seems to solve this in IE6.

    Isn't it the same issue?

    August 21st, 2008 @ 12:56 PM

  8. Nathan L Smith
    Nathan L Smith
    • State changed from unconfirmed to resolved

    The resolution in ticket #18 IE Overlay Height seems to resolve this. Closing.

    May 18th, 2009 @ 04:21 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.