#2 ✓resolved
Ryan Johnson

Control.Overlay does not resize properly on IE

Reported by Ryan Johnson | June 13th, 2008 @ 10:43 AM | in 1.0

With IE7 (Vista)

  • I scroll IE
  • I play with control.modal

=> The overlay is sized to the viewport and not to the full page. So

when scrolled half of the page si with the overlay

Comments and changes to this ticket

  • venu

    venu June 14th, 2008 @ 07:11 AM

    It happens on both IE6 and IE7 not just vista.

    Steps to reproduce:

    1. Open the URL http://livepipe.net/control/window in IE

    2. Click on Model Window link and scroll to the bottom of the screen.

    Expected:

    The overlay should cover the full screen.

  • Ryan Johnson

    Ryan Johnson June 19th, 2008 @ 05:58 PM

    I think this should be fixed in the latest version, can you check?

    Added Control.Overlay.positionOverlay handler on scroll for IE.

  • Rich Sbarro

    Rich Sbarro June 22nd, 2008 @ 06:37 PM

    This issue appears to still exist on the livepipe.net site as of this posting. I also ran into it on my local projects as well.

    Control.Modal works fine in IE7 if there is no scrollbar. If there is a scrollbar, then it will only gray out a portion of the screen, and it will allow the user to scroll the screen.

  • Andy

    Andy July 10th, 2008 @ 10:34 AM

    • Tag set to control.modal, control.overlay, control.window, ie

    document.viewport.getDimensions(); does not return a different value once you scroll/resize. In order to do that, call document.viewport. getScrollOffsets(); and add it to the dimensions.

    Something like:

    var dimensions = document.viewport.getDimensions();

    var offsets = document.viewport.getScrollOffsets();

    Control.Overlay.container.setStyle({

    width: dimensions.width + offsets.left + 'px',

    height: dimensions.height + offsets.top + 'px'

    });

  • Juan

    Juan July 26th, 2008 @ 03:38 AM

    The last tip did not work, as the dimensions were set once but upon scrolling or resizing the overlay still remained in its original spot rather than scrolling with the viewport.

    This, however, fixed it for me (after the modal window opens):

    Control.Overlay.container.setStyle({

    position: 'fixed',

    left: '0px',

    top: '0px',

    right: '0px',

    bottom: '0px'

    });

    might be redundant, but it work.

    Minor glitch: sometimes when resizing in ie, the overlay wont resize immediately but will upon scrolling. shrug

    Hope this helps somebody.

  • Juan

    Juan August 1st, 2008 @ 05:06 PM

    Peter:

    yikes, hadn't noticed that. That's what i get for not testing in IE 6. Thankfully code hasnt made it to test team =).

    Anyway, still got trouble with IE6, I put that inside the options I extend the container with. I also tried putting them in the options directly passed in to the Modal constructor. both get executed, but IE6 just dislikes it.

    Thoughts?

  • Tim Holahan

    Tim Holahan August 21st, 2008 @ 12:56 PM

    The solution proposed in ticket 18 (http://livepipe.lighthouseapp.co... seems to solve this in IE6.

    Isn't it the same issue?

  • Nathan L Smith

    Nathan L Smith May 18th, 2009 @ 04:21 PM

    • State changed from “unconfirmed” to “resolved”

    The resolution in ticket #18 seems to resolve this. Closing.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

NOTE: Please do not open tickets here. If you have an issue, please open it on http://github.com/syntacticx/livepipe-ui/issues/

High quality widgets and controls for web 2.0 applications built using the Prototype JavaScript Framework. Each control is well tested, highly extensible, fully documented and degrades gracefully for non JavaScript enabled browsers where possible. MIT licensed and actively maintained.

Attachments

Pages